Configure yum proxy if given for updates #16972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Feb 8, 2018
| @@ -61,6 +61,7 @@ def attempt_registration | |||
| return unless register | |||
| attach_products | |||
| # HACK: #enable_repos is not always successful immediately after #attach_products, retry to ensure they are enabled. | |||
There was a problem hiding this comment.
This comment applies to the line two below. I think the configure_yum_proxy should be above the comment.
bdunne
force-pushed
the
configure_proxy_info_for_yum_updates
branch
from
48d490c
to
5798d83
Compare
|
Checked commit bdunne@5798d83 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Feb 27, 2018
…dates Configure yum proxy if given for updates (cherry picked from commit 58a6e56) https://bugzilla.redhat.com/show_bug.cgi?id=1549627
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Mar 1, 2018
…dates Configure yum proxy if given for updates (cherry picked from commit 58a6e56) https://bugzilla.redhat.com/show_bug.cgi?id=1549626
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
…dates Configure yum proxy if given for updates (cherry picked from commit 58a6e56) https://bugzilla.redhat.com/show_bug.cgi?id=1549625
|
Gaprindashvili backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…r_yum_updates Configure yum proxy if given for updates (cherry picked from commit 58a6e56) https://bugzilla.redhat.com/show_bug.cgi?id=1549626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1540550